Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert not to use grpc/credentials/insecure for compatibility #407

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Apr 26, 2022

Description

We must have compatibility of grpc-v1.33.2. I revert not to use grpc/credentials/insecure.

See:

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #407 (d3c67e1) into main (9615276) will increase coverage by 0.13%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   65.16%   65.30%   +0.13%     
==========================================
  Files         277      277              
  Lines       37832    37842      +10     
==========================================
+ Hits        24653    24711      +58     
+ Misses      11373    11313      -60     
- Partials     1806     1818      +12     
Impacted Files Coverage Δ
crypto/vrf/vrf_r2ishiguro.go 100.00% <ø> (ø)
mempool/errors.go 25.00% <ø> (ø)
privval/file.go 74.90% <0.00%> (-0.10%) ⬇️
cmd/ostracon/commands/reset.go 50.44% <80.00%> (ø)
abci/client/grpc_client.go 69.37% <100.00%> (-0.12%) ⬇️
mempool/clist_mempool.go 82.41% <100.00%> (-0.68%) ⬇️
rpc/grpc/client_server.go 83.33% <100.00%> (-1.29%) ⬇️
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
privval/socket_listeners.go 79.72% <0.00%> (-4.06%) ⬇️
privval/signer_listener_endpoint.go 88.88% <0.00%> (-2.39%) ⬇️
... and 10 more

@tnasu tnasu marked this pull request as ready for review April 27, 2022 02:51
@tnasu tnasu requested review from Kynea0b and torao as code owners April 27, 2022 02:51
@torao torao added the C: bug Classification: Something isn't working label Apr 27, 2022
@tnasu tnasu merged commit 2d8cb08 into Finschia:main Apr 27, 2022
@tnasu tnasu deleted the main-keep-compatibility-for-lbm-sdk branch April 28, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants